Skip to main content

Check for python builtins being used as variables or parameters

Project description

https://github.com/gforcada/flake8-builtins/actions/workflows/testing.yml/badge.svg?branch=main https://coveralls.io/repos/gforcada/flake8-builtins/badge.svg?branch=main

Flake8 Builtins plugin

Check for python builtins being used as variables or parameters.

Imagine some code like this:

def max_values(list, list2):
    max = list[0]
    for x in list:
        if x > 0:
            max = x

    all_values = list()
    all_values.append(max)

    max = list2[0]
    for x in list2:
        if x > 0:
            max = x
    all_values.append(max)

    return all_values

max_values([3, 4, 5, ], [5, 6, 7])

The last statement is not returning [5, 7] as one would expect, instead is raising this exception:

Traceback (most recent call last):
  File "test.py", line 17, in <module>
    max_values([3,4,5], [4,5,6])
  File "bla.py", line 6, in max_values
    all_values = list()
TypeError: 'list' object is not callable

Why? Because max_value function’s first argument is list a Python builtin. Python allows to override them, but although could be useful in some really specific use cases, the general approach is to not do that as code then can suddenly break without a clear trace.

Example

Given the following code:

def my_method(object, list, dict):
    max = 5
    min = 3
    zip = (4, 3)

The following warnings are shown (via flake8):

test.py:1:15: A002 argument "object" is shadowing a python builtin
test.py:1:23: A002 argument "list" is shadowing a python builtin
test.py:1:29: A002 argument "dict" is shadowing a python builtin
test.py:2:5: A001 variable "max" is shadowing a python builtin
test.py:3:5: A001 variable "min" is shadowing a python builtin
test.py:4:5: A001 variable "zip" is shadowing a python builtin

Install

Install with pip:

$ python -m pip install flake8-builtins

Options

One can use –builtins-ignorelist option, or configuration option, to ignore a custom list of builtins:

$ flake8 --builtins-ignorelist id,copyright *.py

Requirements

  • Python 3.8, 3.9, 3.10, 3.11, and pypy3

  • flake8

Rules

A001:

A variable is shadowing a Python builtin.

A002:

An argument is shadowing a Python builtin.

A003:

A class attribute is shadowing a Python builtin.

A004:

An import statement is shadowing a Python builtin.

License

GPL 2.0

Project details


Download files

Download the file for your platform. If you're not sure which to choose, learn more about installing packages.

Source Distribution

flake8_builtins-2.2.0.tar.gz (17.5 kB view details)

Uploaded Source

Built Distribution

flake8_builtins-2.2.0-py3-none-any.whl (18.5 kB view details)

Uploaded Python 3

File details

Details for the file flake8_builtins-2.2.0.tar.gz.

File metadata

  • Download URL: flake8_builtins-2.2.0.tar.gz
  • Upload date:
  • Size: 17.5 kB
  • Tags: Source
  • Uploaded using Trusted Publishing? No
  • Uploaded via: twine/4.0.2 CPython/3.8.18

File hashes

Hashes for flake8_builtins-2.2.0.tar.gz
Algorithm Hash digest
SHA256 392d5af3a0720c5a863aa93dc47f48c879081345a143fe9f20d995fe9ff5686a
MD5 55b77ca583696c4a96ba350d0ae6796a
BLAKE2b-256 9bb95d14821917127d374523978fd2c31a70f771bb8510cccf57b3cc32c3990d

See more details on using hashes here.

File details

Details for the file flake8_builtins-2.2.0-py3-none-any.whl.

File metadata

File hashes

Hashes for flake8_builtins-2.2.0-py3-none-any.whl
Algorithm Hash digest
SHA256 7ee5766d9c60e5d579dfda84e65c6d0e6c26005f6f59cb9bf722462d7987a807
MD5 7cad069bfc058f163f4ad4a88527b006
BLAKE2b-256 14c65e4cbc348b7509b1fe7fafe322a9c9f2155e1307331e5b00c3d02520b2fd

See more details on using hashes here.

Supported by

AWS Cloud computing and Security Sponsor Datadog Monitoring Fastly CDN Google Download Analytics Pingdom Monitoring Sentry Error logging StatusPage Status page