Skip to main content

Check for python builtins being used as variables or parameters

Project description

https://github.com/gforcada/flake8-builtins/actions/workflows/testing.yml/badge.svg?branch=main https://coveralls.io/repos/gforcada/flake8-builtins/badge.svg?branch=main

Flake8 Builtins plugin

Check for python builtins being used as variables or parameters.

Imagine some code like this:

def max_values(list, list2):
    max = list[0]
    for x in list:
        if x > 0:
            max = x

    all_values = list()
    all_values.append(max)

    max = list2[0]
    for x in list2:
        if x > 0:
            max = x
    all_values.append(max)

    return all_values

max_values([3, 4, 5, ], [5, 6, 7])

The last statement is not returning [5, 7] as one would expect, instead is raising this exception:

Traceback (most recent call last):
  File "test.py", line 17, in <module>
    max_values([3,4,5], [4,5,6])
  File "bla.py", line 6, in max_values
    all_values = list()
TypeError: 'list' object is not callable

Why? Because max_value function’s first argument is list a Python builtin. Python allows to override them, but although could be useful in some really specific use cases, the general approach is to not do that as code then can suddenly break without a clear trace.

Example

Given the following code:

def my_method(object, list, dict):
    max = 5
    min = 3
    zip = (4, 3)

The following warnings are shown (via flake8):

test.py:1:15: A002 argument "object" is shadowing a python builtin
test.py:1:23: A002 argument "list" is shadowing a python builtin
test.py:1:29: A002 argument "dict" is shadowing a python builtin
test.py:2:5: A001 variable "max" is shadowing a python builtin
test.py:3:5: A001 variable "min" is shadowing a python builtin
test.py:4:5: A001 variable "zip" is shadowing a python builtin

Install

Install with pip:

$ python -m pip install flake8-builtins

Options

One can use –builtins-ignorelist option, or configuration option, to ignore a custom list of builtins:

$ flake8 --builtins-ignorelist id,copyright *.py

Requirements

  • Python 3.8, 3.9, 3.10, 3.11, 3.12, and pypy3

  • flake8

Rules

A001:

A variable is shadowing a Python builtin.

A002:

An argument is shadowing a Python builtin.

A003:

A class attribute is shadowing a Python builtin.

A004:

An import statement is shadowing a Python builtin.

A005:

A module is shadowing a Python builtin module (e.g: logging or socket)

License

GPL 2.0

Project details


Download files

Download the file for your platform. If you're not sure which to choose, learn more about installing packages.

Source Distribution

flake8_builtins-2.3.0.tar.gz (16.3 kB view details)

Uploaded Source

Built Distribution

flake8_builtins-2.3.0-py3-none-any.whl (11.9 kB view details)

Uploaded Python 3

File details

Details for the file flake8_builtins-2.3.0.tar.gz.

File metadata

  • Download URL: flake8_builtins-2.3.0.tar.gz
  • Upload date:
  • Size: 16.3 kB
  • Tags: Source
  • Uploaded using Trusted Publishing? No
  • Uploaded via: twine/4.0.2 CPython/3.8.18

File hashes

Hashes for flake8_builtins-2.3.0.tar.gz
Algorithm Hash digest
SHA256 c3669520104233356c1909389d1b5016107c93f4c494922e829fd3c65c10c81c
MD5 2ba52be71ba5b3193f8936abd9f5ab2c
BLAKE2b-256 0ca702aad6d96ba2ead6c20fc0469520000f038ac1219ed911723a2f1882c3a3

See more details on using hashes here.

File details

Details for the file flake8_builtins-2.3.0-py3-none-any.whl.

File metadata

File hashes

Hashes for flake8_builtins-2.3.0-py3-none-any.whl
Algorithm Hash digest
SHA256 2db907d96d2817beb3c861d46fad8dde647e76894c6af88a6cc91dd7c3c58bc6
MD5 ed0a5a17d1a289117e7e5ef5c759e843
BLAKE2b-256 b8c05cc9b0a4d97899bf23a810e54a8c37c95cf2d7119d55ae36d4dc6de6f8ec

See more details on using hashes here.

Supported by

AWS Cloud computing and Security Sponsor Datadog Monitoring Fastly CDN Google Download Analytics Pingdom Monitoring Sentry Error logging StatusPage Status page